Impact Efficiency Report: progressive disclosure + fix artificial/missing data + recommendations#39830
Impact Efficiency Report: progressive disclosure + fix artificial/missing data + recommendations#39830Copilot wants to merge 10 commits into
Conversation
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
…cial/missing data - Add HTML details/summary progressive disclosure for all sections except Executive Summary (which stays always visible on top) - Summary labels include key numbers at-a-glance (accepted count, AIC, IE) - Replace "artificially depressed" IE language with scope-adjusted IE computation: also report IE against only outcome-producing workflows - Show — instead of N/A for unknown per-category AIC/IE - Human Work section now filters likely-agentic PRs by title pattern ([docs], [linter-miner], [fix], bot accounts) into a separate sub-table to prevent attribution gaps from inflating the human count - Recompile lock file Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
|
@copilot Add actionable recommendations to improve the accuracy and evidence for this report. It should be based on deterministic outcomes and objective values and attributed workflows can be directly attributed. |
Generate actionable, evidence-grounded recommendations from each cycle's data quality gaps: workflow attribution, linked-issue coverage, objective label coverage, AIC per-outcome attribution, PR dataset cap, and likely-agentic reclassification. Each recommendation includes the specific gap with concrete numbers, expected effect on report accuracy, and the owner/mechanism. Only recommendations confirmed by the cycle's data are emitted. Recompile lock file. Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Added a
The six covered gap categories are: workflow attribution (direct |
|
@copilot Revert |
The recompile step moved the zizmor ignore comment from a standalone line to an inline comment; restore the original formatting. Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Reverted in the latest commit. The |
There was a problem hiding this comment.
Pull request overview
Improves the “Impact Efficiency Report” workflow instructions to generate more readable and actionable GitHub issues by introducing progressive disclosure formatting, refining metric language/definitions, correcting attribution-related counting guidance, and adding evidence-grounded recommendations.
Changes:
- Adds progressive disclosure guidance for report sections using collapsible
<details><summary>blocks while keeping the Executive Summary always visible. - Replaces “artificially depressed” framing with a scope-adjusted IE concept and clearer denominator explanation, plus
—for structurally-unknown AIC/IE. - Updates Human Work guidance to split “likely agentic (attribution gap)” from confirmed human, and adds a Recommendations section driven by observed gaps.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/objective-impact-report.md | Updates report-generation instructions: progressive disclosure, scope-adjusted IE guidance, attribution-gap handling, and evidence-based recommendations. |
| .github/workflows/objective-impact-report.lock.yml | Regenerates compiled lock metadata to reflect the markdown workflow changes. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 4
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
@copilot Recompile workflow |
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Done — |
|
@copilot fix the failing validate-yaml check, then rerun CI and recompile the workflow lock if needed.
|
|
Hey One thing to address before merging:
If you'd like a hand, you can assign this prompt to your coding agent:
|
|
Please add or update test coverage for .github/workflows/objective-impact-report.md, then rerun CI if needed.
|
The generated report (e.g. issue #39811) was a wall of text with no collapsing, used "artificially depressed" to describe a computable metric, inflated the Human Work count by counting likely-agentic PRs as human due to attribution gaps, and provided no guidance on how to improve accuracy in future cycles.
Progressive disclosure
Summary,Agentic Work by Objective,Which Workflows Drove That Impact,Top Outcomes,Unmapped Outcomes,Interpretation,Data Quality,Recommendations,Human Work) is wrapped in<details><summary>with a label that includes the section's key numberScope-adjusted IE replaces "artificially depressed"
Human Work attribution gap
[docs],[linter-miner],[fix], etc.) and bot authors into a separate "Likely agentic (attribution gap)" sub-tableN/A →
—for unknown per-category AIC/IE—(notN/A) when workflow attribution is missing, with a precise note that attribution is structurally absent — not computed as zeroActionable Recommendations
Recommendationssection placed between Data Quality and Human Workworkflow_run_idstamping), linked-issue coverage, objective label coverage (lists the specific unmapped labels observed), AIC per-outcome attribution (minimal dataset join needed), PR dataset cap, and likely-agentic reclassification