Update authenticating-to-the-rest-api-with-an-oauth-app.md - #45672
Open
Proman4713 wants to merge 1 commit into
Open
Update authenticating-to-the-rest-api-with-an-oauth-app.md#45672Proman4713 wants to merge 1 commit into
Proman4713 wants to merge 1 commit into
Conversation
The primary check should be for refresh_token, not access_token, since that more closely resembles production environments were the user's access token will expire first. The rest of the code should play out the same, with the subsequent requests failing if the access token is absent or invalid
Contributor
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options: A Hubber will need to deploy your changes internally to review. Table of review linksNote: Please update the URL for your staging server or codespace. The table shows the files in the
Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server 🤖 This comment is automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The primary check should be for refresh_token, not access_token, since that more closely resembles production environments where the user's access token will expire first. The rest of the code should play out the same, with the subsequent requests failing if the access token is absent or invalid
Why:
It initially misled me while I was trying to understand what GitHub's authentication flow with OAuth apps is supposed to be.
Closes: #45671
What's being changed (if available, include any code snippets, screenshots, or gifs):
Before:
After:
Check off the following: