Skip to content

JS: Mass promotion of queries to quality status #19776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,9 +1,98 @@
ql/javascript/ql/src/AngularJS/DependencyMismatch.ql
ql/javascript/ql/src/AngularJS/DuplicateDependency.ql
ql/javascript/ql/src/AngularJS/IncompatibleService.ql
ql/javascript/ql/src/AngularJS/MissingExplicitInjection.ql
ql/javascript/ql/src/AngularJS/RepeatedInjection.ql
ql/javascript/ql/src/AngularJS/UseNgSrc.ql
ql/javascript/ql/src/DOM/DuplicateAttributes.ql
ql/javascript/ql/src/DOM/MalformedIdAttribute.ql
ql/javascript/ql/src/DOM/PseudoEval.ql
ql/javascript/ql/src/Declarations/ArgumentsRedefined.ql
ql/javascript/ql/src/Declarations/AssignmentToConst.ql
ql/javascript/ql/src/Declarations/ClobberingVarInit.ql
ql/javascript/ql/src/Declarations/ConflictingFunctions.ql
ql/javascript/ql/src/Declarations/DeadStoreOfLocal.ql
ql/javascript/ql/src/Declarations/DeadStoreOfProperty.ql
ql/javascript/ql/src/Declarations/DeclBeforeUse.ql
ql/javascript/ql/src/Declarations/DefaultArgumentReferencesNestedFunction.ql
ql/javascript/ql/src/Declarations/DuplicateVarDecl.ql
ql/javascript/ql/src/Declarations/IneffectiveParameterType.ql
ql/javascript/ql/src/Declarations/MissingThisQualifier.ql
ql/javascript/ql/src/Declarations/MissingVarDecl.ql
ql/javascript/ql/src/Declarations/MixedStaticInstanceThisAccess.ql
ql/javascript/ql/src/Declarations/SuspiciousMethodNameDeclaration.ql
ql/javascript/ql/src/Declarations/TemporalDeadZone.ql
ql/javascript/ql/src/Declarations/UniqueParameterNames.ql
ql/javascript/ql/src/Declarations/UniquePropertyNames.ql
ql/javascript/ql/src/Declarations/UnreachableMethodOverloads.ql
ql/javascript/ql/src/Declarations/UnusedVariable.ql
ql/javascript/ql/src/Expressions/ComparisonWithNaN.ql
ql/javascript/ql/src/Expressions/DuplicateCondition.ql
ql/javascript/ql/src/Expressions/DuplicateProperty.ql
ql/javascript/ql/src/Expressions/DuplicateSwitchCase.ql
ql/javascript/ql/src/Expressions/ExprHasNoEffect.ql
ql/javascript/ql/src/Expressions/HeterogeneousComparison.ql
ql/javascript/ql/src/Expressions/ImplicitOperandConversion.ql
ql/javascript/ql/src/Expressions/MissingAwait.ql
ql/javascript/ql/src/Expressions/MissingDotLengthInComparison.ql
ql/javascript/ql/src/Expressions/MissingSpaceInAppend.ql
ql/javascript/ql/src/Expressions/MisspelledVariableName.ql
ql/javascript/ql/src/Expressions/RedundantExpression.ql
ql/javascript/ql/src/Expressions/SelfAssignment.ql
ql/javascript/ql/src/Expressions/ShiftOutOfRange.ql
ql/javascript/ql/src/Expressions/StringInsteadOfRegex.ql
ql/javascript/ql/src/Expressions/SuspiciousInvocation.ql
ql/javascript/ql/src/Expressions/SuspiciousPropAccess.ql
ql/javascript/ql/src/Expressions/UnboundEventHandlerReceiver.ql
ql/javascript/ql/src/Expressions/UnclearOperatorPrecedence.ql
ql/javascript/ql/src/Expressions/UnknownDirective.ql
ql/javascript/ql/src/Expressions/UnneededDefensiveProgramming.ql
ql/javascript/ql/src/Expressions/WhitespaceContradictsPrecedence.ql
ql/javascript/ql/src/LanguageFeatures/BadTypeof.ql
ql/javascript/ql/src/LanguageFeatures/ConditionalComments.ql
ql/javascript/ql/src/LanguageFeatures/DeleteVar.ql
ql/javascript/ql/src/LanguageFeatures/ExpressionClosures.ql
ql/javascript/ql/src/LanguageFeatures/ForInComprehensionBlocks.ql
ql/javascript/ql/src/LanguageFeatures/IllegalInvocation.ql
ql/javascript/ql/src/LanguageFeatures/InconsistentNew.ql
ql/javascript/ql/src/LanguageFeatures/InvalidPrototype.ql
ql/javascript/ql/src/LanguageFeatures/LengthComparisonOffByOne.ql
ql/javascript/ql/src/LanguageFeatures/NonLinearPattern.ql
ql/javascript/ql/src/LanguageFeatures/PropertyWriteOnPrimitive.ql
ql/javascript/ql/src/LanguageFeatures/SemicolonInsertion.ql
ql/javascript/ql/src/LanguageFeatures/SetterReturn.ql
ql/javascript/ql/src/LanguageFeatures/SpuriousArguments.ql
ql/javascript/ql/src/LanguageFeatures/StrictModeCallStackIntrospection.ql
ql/javascript/ql/src/LanguageFeatures/SyntaxError.ql
ql/javascript/ql/src/LanguageFeatures/TemplateSyntaxInStringLiteral.ql
ql/javascript/ql/src/LanguageFeatures/ThisBeforeSuper.ql
ql/javascript/ql/src/LanguageFeatures/UnusedIndexVariable.ql
ql/javascript/ql/src/LanguageFeatures/WithStatement.ql
ql/javascript/ql/src/LanguageFeatures/YieldInNonGenerator.ql
ql/javascript/ql/src/NodeJS/InvalidExport.ql
ql/javascript/ql/src/NodeJS/MissingExports.ql
ql/javascript/ql/src/Quality/UnhandledErrorInStreamPipeline.ql
ql/javascript/ql/src/React/DirectStateMutation.ql
ql/javascript/ql/src/React/InconsistentStateUpdate.ql
ql/javascript/ql/src/React/UnsupportedStateUpdateInLifecycleMethod.ql
ql/javascript/ql/src/React/UnusedOrUndefinedStateProperty.ql
ql/javascript/ql/src/RegExp/BackrefBeforeGroup.ql
ql/javascript/ql/src/RegExp/BackrefIntoNegativeLookahead.ql
ql/javascript/ql/src/RegExp/DuplicateCharacterInCharacterClass.ql
ql/javascript/ql/src/RegExp/EmptyCharacterClass.ql
ql/javascript/ql/src/RegExp/RegExpAlwaysMatches.ql
ql/javascript/ql/src/RegExp/UnboundBackref.ql
ql/javascript/ql/src/RegExp/UnmatchableCaret.ql
ql/javascript/ql/src/RegExp/UnmatchableDollar.ql
ql/javascript/ql/src/Statements/DanglingElse.ql
ql/javascript/ql/src/Statements/IgnoreArrayResult.ql
ql/javascript/ql/src/Statements/InconsistentLoopOrientation.ql
ql/javascript/ql/src/Statements/LabelInCase.ql
ql/javascript/ql/src/Statements/MisleadingIndentationAfterControlStmt.ql
ql/javascript/ql/src/Statements/ReturnAssignsLocal.ql
ql/javascript/ql/src/Statements/SuspiciousUnusedLoopIterationVariable.ql
ql/javascript/ql/src/Statements/UnreachableStatement.ql
ql/javascript/ql/src/Statements/UseOfReturnlessFunction.ql
ql/javascript/ql/src/Statements/UselessComparisonTest.ql
ql/javascript/ql/src/Statements/UselessConditional.ql
ql/javascript/ql/src/Vue/ArrowMethodOnVueInstance.ql
3 changes: 2 additions & 1 deletion javascript/ql/src/AngularJS/DependencyMismatch.ql
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@
* @problem.severity warning
* @precision very-high
* @id js/angular/dependency-injection-mismatch
* @tags correctness
* @tags quality
* maintainability
* readability
* frameworks/angularjs
*/

Expand Down
4 changes: 3 additions & 1 deletion javascript/ql/src/AngularJS/DuplicateDependency.ql
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@
* @problem.severity warning
* @precision very-high
* @id js/angular/duplicate-dependency
* @tags maintainability
* @tags quality
* maintainability
* readability
* frameworks/angularjs
*/

Expand Down
4 changes: 3 additions & 1 deletion javascript/ql/src/AngularJS/IncompatibleService.ql
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@
* @problem.severity error
* @precision high
* @id js/angular/incompatible-service
* @tags correctness
* @tags quality
* reliability
* correctness
* frameworks/angularjs
*/

Expand Down
5 changes: 3 additions & 2 deletions javascript/ql/src/AngularJS/MissingExplicitInjection.ql
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@
* @problem.severity warning
* @precision high
* @id js/angular/missing-explicit-injection
* @tags correctness
* maintainability
* @tags quality
* reliability
* correctness
* frameworks/angularjs
*/

Expand Down
4 changes: 3 additions & 1 deletion javascript/ql/src/AngularJS/RepeatedInjection.ql
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@
* @problem.severity warning
* @precision high
* @id js/angular/repeated-dependency-injection
* @tags maintainability
* @tags quality
* maintainability
* readability
* frameworks/angularjs
*/

Expand Down
4 changes: 3 additions & 1 deletion javascript/ql/src/AngularJS/UseNgSrc.ql
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@
* @problem.severity warning
* @precision very-high
* @id js/angular/expression-in-url-attribute
* @tags maintainability
* @tags quality
* reliability
* correctness
* frameworks/angularjs
*/

Expand Down
3 changes: 2 additions & 1 deletion javascript/ql/src/DOM/DuplicateAttributes.ql
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
* @kind problem
* @problem.severity warning
* @id js/duplicate-html-attribute
* @tags maintainability
* @tags quality
* maintainability
* readability
* @precision very-high
*/
Expand Down
3 changes: 2 additions & 1 deletion javascript/ql/src/DOM/MalformedIdAttribute.ql
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
* @kind problem
* @problem.severity warning
* @id js/malformed-html-id
* @tags maintainability
* @tags quality
* reliability
* correctness
* external/cwe/cwe-758
* @precision very-high
Expand Down
6 changes: 4 additions & 2 deletions javascript/ql/src/DOM/PseudoEval.ql
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,10 @@
* @kind problem
* @problem.severity recommendation
* @id js/eval-like-call
* @tags maintainability
* external/cwe/cwe-676
* @tags quality
* maintainability
* readability
* external/cwe/cwe-67
* @precision very-high
*/

Expand Down
5 changes: 3 additions & 2 deletions javascript/ql/src/Declarations/ArgumentsRedefined.ql
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@
* @kind problem
* @problem.severity recommendation
* @id js/arguments-redefinition
* @tags efficiency
* maintainability
* @tags quality
* reliability
* performance
* @precision very-high
*/

Expand Down
3 changes: 2 additions & 1 deletion javascript/ql/src/Declarations/AssignmentToConst.ql
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
* @kind problem
* @problem.severity error
* @id js/assignment-to-constant
* @tags reliability
* @tags quality
* reliability
* correctness
* @precision very-high
*/
Expand Down
3 changes: 2 additions & 1 deletion javascript/ql/src/Declarations/ClobberingVarInit.ql
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
* @kind problem
* @problem.severity error
* @id js/variable-initialization-conflict
* @tags reliability
* @tags quality
* reliability
* correctness
* external/cwe/cwe-563
* @precision very-high
Expand Down
3 changes: 2 additions & 1 deletion javascript/ql/src/Declarations/ConflictingFunctions.ql
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
* @kind problem
* @problem.severity error
* @id js/function-declaration-conflict
* @tags reliability
* @tags quality
* reliability
* correctness
* external/cwe/cwe-563
* @precision high
Expand Down
4 changes: 3 additions & 1 deletion javascript/ql/src/Declarations/DeadStoreOfLocal.ql
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@
* @kind problem
* @problem.severity warning
* @id js/useless-assignment-to-local
* @tags maintainability
* @tags quality
* maintainability
* useless-code
* external/cwe/cwe-563
* @precision very-high
*/
Expand Down
4 changes: 3 additions & 1 deletion javascript/ql/src/Declarations/DeadStoreOfProperty.ql
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@
* @kind problem
* @problem.severity warning
* @id js/useless-assignment-to-property
* @tags maintainability
* @tags quality
* maintainability
* useless-code
* @precision high
*/

Expand Down
3 changes: 2 additions & 1 deletion javascript/ql/src/Declarations/DeclBeforeUse.ql
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
* @kind problem
* @problem.severity warning
* @id js/use-before-declaration
* @tags maintainability
* @tags quality
* maintainability
* readability
* @precision very-high
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
* @kind problem
* @problem.severity error
* @id js/nested-function-reference-in-default-parameter
* @tags reliability
* @tags quality
* reliability
* correctness
* @precision very-high
*/
Expand Down
4 changes: 3 additions & 1 deletion javascript/ql/src/Declarations/DuplicateVarDecl.ql
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@
* @kind problem
* @problem.severity recommendation
* @id js/duplicate-variable-declaration
* @tags maintainability
* @tags quality
* maintainability
* readability
* @precision very-high
*/

Expand Down
5 changes: 3 additions & 2 deletions javascript/ql/src/Declarations/IneffectiveParameterType.ql
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,10 @@
* @problem.severity warning
* @id js/ineffective-parameter-type
* @precision high
* @tags correctness
* @tags quality
* reliability
* correctness
* typescript
* quality
*/

import javascript
Expand Down
5 changes: 3 additions & 2 deletions javascript/ql/src/Declarations/MissingThisQualifier.ql
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@
* @kind problem
* @problem.severity error
* @id js/missing-this-qualifier
* @tags maintainability
* correctness
* @tags quality
* maintainability
* readability
* methods
* @precision high
*/
Expand Down
5 changes: 3 additions & 2 deletions javascript/ql/src/Declarations/MissingVarDecl.ql
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@
* @kind problem
* @problem.severity warning
* @id js/missing-variable-declaration
* @tags reliability
* maintainability
* @tags quality
* reliability
* correctness
* @precision high
*/

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@
* @kind problem
* @problem.severity error
* @id js/mixed-static-instance-this-access
* @tags correctness
* @tags quality
* reliability
* correctness
* methods
* @precision high
*/
Expand Down
4 changes: 3 additions & 1 deletion javascript/ql/src/Declarations/TemporalDeadZone.ql
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,10 @@
* @kind problem
* @problem.severity error
* @id js/variable-use-in-temporal-dead-zone
* @tags portability
* @tags quality
* reliability
* correctness
* portability
* @precision very-high
*/

Expand Down
3 changes: 2 additions & 1 deletion javascript/ql/src/Declarations/UniqueParameterNames.ql
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
* @kind problem
* @problem.severity error
* @id js/duplicate-parameter-name
* @tags reliability
* @tags quality
* reliability
* correctness
* @precision very-high
*/
Expand Down
3 changes: 2 additions & 1 deletion javascript/ql/src/Declarations/UniquePropertyNames.ql
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
* @kind problem
* @problem.severity error
* @id js/overwritten-property
* @tags reliability
* @tags quality
* reliability
* correctness
* external/cwe/cwe-563
* @precision very-high
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@
* @problem.severity warning
* @id js/unreachable-method-overloads
* @precision high
* @tags correctness
* @tags quality
* reliability
* correctness
* typescript
*/

Expand Down
4 changes: 3 additions & 1 deletion javascript/ql/src/Declarations/UnusedVariable.ql
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@
* @kind problem
* @problem.severity recommendation
* @id js/unused-local-variable
* @tags maintainability
* @tags quality
* maintainability
* useless-code
* @precision very-high
*/

Expand Down
Loading