Skip to content

PR checks: support collections of workflows #3030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 14, 2025
Merged

Conversation

mbg
Copy link
Member

@mbg mbg commented Aug 12, 2025

This is a sort-of experimental idea that I had in the context of #3028 where we bump the Go version in the workflows to a release candidate for testing purposes, but such PRs don't have to be merged anymore because the existing constraint of >= 1.22 would include allow new version once it is fully released.

This PR updates the sync.py script to allow "collections" of PR checks that can be triggered manually, with specific inputs. So instead of creating a PR that bumps the Go version for testing purposes only, we could instead just dispatch the collection workflow with the desired Go version.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

@mbg mbg marked this pull request as ready for review August 12, 2025 11:53
@mbg mbg requested a review from a team as a code owner August 12, 2025 11:53
@Copilot Copilot AI review requested due to automatic review settings August 12, 2025 11:53
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for collections of workflows in the PR checks system. It allows grouping related workflow checks (like Go-related checks) into collections that can be executed together.

  • Adds collection functionality to the PR checks sync script
  • Introduces workflow inputs for parameterizing check execution
  • Creates a consolidated "go" collection containing all Go-related checks

Reviewed Changes

Copilot reviewed 64 out of 64 changed files in this pull request and generated 1 comment.

File Description
pr-checks/sync.py Main implementation adding collection support and workflow input handling
pr-checks/checks/go-*.yml Go check specifications updated with collection membership and inputs
.github/workflows/__go.yml New generated collection workflow for running all Go checks together
.github/workflows/__*.yml Generated workflow files updated with workflow_call and workflow_dispatch inputs

henrymercer
henrymercer previously approved these changes Aug 13, 2025
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I like this. There is a little bit of awkwardness in the "go-version" input not being used in any of the steps, but it's not blocking.

@mbg mbg force-pushed the mbg/workflow-collections branch from c3ee05b to 20c329c Compare August 14, 2025 11:09
@mbg mbg requested a review from henrymercer August 14, 2025 11:17
@mbg
Copy link
Member Author

mbg commented Aug 14, 2025

I manually dispatched a run of __go.yml with a Go RC as input to check that all works as expected with the workflow_dispatch and workflow_call triggers: https://github.com/github/codeql-action/actions/runs/16963696649

Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for the extra cleanup!

@mbg mbg merged commit 777f917 into main Aug 14, 2025
390 checks passed
@mbg mbg deleted the mbg/workflow-collections branch August 14, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants