Recognize webp as a valid image format#7535
Draft
khiga8 wants to merge 1 commit intogithub-linguist:mainfrom
Draft
Recognize webp as a valid image format#7535khiga8 wants to merge 1 commit intogithub-linguist:mainfrom
khiga8 wants to merge 1 commit intogithub-linguist:mainfrom
Conversation
Alhadis
reviewed
Aug 20, 2025
Collaborator
Alhadis
left a comment
There was a problem hiding this comment.
The array that you're modifying… does it influence which filetypes are "viewable" as images on GitHub? If so, you should consider supporting other image formats that are supported by browsers (either contemporaneously or historically) but not rendered by the site's file-viewer:
def image?
%w[
.apng .avif .bmp .cur .gif
.heic .ico .jpg .jpeg .png
.tif .tiff .webp
].include?(extname.downcase)
end
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist:
I am adding a new extension to a language.
I am adding a new language.
#RRGGBBI am fixing a misclassified language
I am changing the source of a syntax highlighting grammar
I am updating a grammar submodule
I am adding new or changing current functionality
I am changing the color associated with a language