Add support for DataFlex language#7479
Open
sonnyfalk wants to merge 4 commits intogithub-linguist:mainfrom
Open
Add support for DataFlex language#7479sonnyfalk wants to merge 4 commits intogithub-linguist:mainfrom
sonnyfalk wants to merge 4 commits intogithub-linguist:mainfrom
Conversation
This adds DataFlex language support for `.pkg` file extension with strict heuristics requiring both a Use statement and a class or function/procedure.
lildude
requested changes
Jul 3, 2025
Member
lildude
left a comment
There was a problem hiding this comment.
See inline comments.
samples/DataFlex/FileType.pkg is also too big; if the diff suppresses it, it’s too big for our needs. Please replace it.
…s too, and merge rules for .pkg extension so the language only appears once.
sonnyfalk
commented
Jul 3, 2025
Author
|
I've made all the changes to address the comments. Please let me know if there's something else that I need to do for this to get merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds DataFlex language support for
.pkgfile extension with strict heuristics requiring both a Use statement and a class or function/procedure definition. This will resolve issue #7171.The main DataFlex language website is https://www.dataflex.dev.
Description
As discussed in issue #7171, the most common DataFlex source file extension is
.pkg. Since it's a pretty generic extension, this adds it togeneric.ymlwith some strict rules inheuristics.ymland corresponding tests.Checklist:
#ff5f1f.pkgfile extension.