feat(github-app): select app by rate limit budget - #5283
Open
guicaulada wants to merge 2 commits into
Open
Conversation
Replace uniform random GitHub App selection with budget-aware selection. The auth module tracks the last observed x-ratelimit-remaining per app (fed by response headers and the throttling plugin callbacks) and selects the app with the most budget left. Apps that hit a secondary rate limit are skipped for 60 seconds. Iteration starts at a random offset so concurrent cold-started lambdas do not converge on the same app. Uniform random selection kept sending ~1/N of traffic to apps that were already exhausted or throttled. Selection state is per warm container and converges within a few invocations.
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #5269, item 2 of the #5038 review. Stacked on #5282 (manifest transport); review that first.
Replaces uniform random GitHub App selection with budget-aware selection, ported from our production fork:
x-ratelimit-remainingper app, fed bymetricGitHubAppRateLimitheaders and the throttling plugin callbacks.Uniform random kept sending ~1/N of traffic to apps that were already exhausted. Selection state is per warm container and converges within a few invocations; a cold container starts as before.
Test Plan
Related Issues
Follow-up to #5269 / #5038. Depends on #5282.