Skip to content

Conversation

@qmonnet
Copy link
Member

@qmonnet qmonnet commented Nov 13, 2025

I'm not sure this is the right approach; this looks like a lot of data cloning for not too much gain.

Fixes: #554

TO DO:

  • Use validated types for .device and .underlay in ValidatedExternalConfig
  • Commit titles + descriptions

@qmonnet qmonnet added area/nat Related to Network Address Translation (NAT) and removed area/nat Related to Network Address Translation (NAT) labels Nov 13, 2025
@qmonnet qmonnet self-assigned this Nov 13, 2025
@Fredi-raspall
Copy link
Contributor

I'm not sure this is the right approach; this looks like a lot of data cloning for not too much gain.

I think I would wait until the new API is in place, esp. if you comment that the gain is minor?

Raising this because Vpcs and Peering objects may soon be gone.
So, a better exercise would be to see how we model the pieces of information that particularly NAT requires in preparation for such a change?

+cc @mvachhar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create “validated” types for VpcExpose and friends

3 participants