Skip to content

[DRAFT] feat: add a bullet image #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alasdairmackenzie
Copy link

@alasdairmackenzie alasdairmackenzie commented Feb 22, 2021

Hey, this is a draft PR for #898

Hoping to get some feedback if possible -

My main issue that the image is added to the slide at x:0 and y:0 rather than hiding it. I'm not sure this is the best way to go. What are your thoughts on modifying the addImageDefinition function to create a 'hidden' image? Do you have another suggestion?

It's be great to hear your thoughts

(Ignore the changes to index.html and the typescript hack for now)

@alasdairmackenzie alasdairmackenzie marked this pull request as draft February 22, 2021 23:13
@alasdairmackenzie alasdairmackenzie changed the title feat: add a bullet image [DRAFT] feat: add a bullet image Feb 22, 2021
@gitbrent
Copy link
Owner

Hi Alasdair,

Are you saying that PowerPoint is showing the image at (0,0) in addition to being the bullet itself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants