Skip to content

Decimal fontsizes and Breakline Fix #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Decimal fontsizes and Breakline Fix #871

wants to merge 10 commits into from

Conversation

Martin-N
Copy link

No description provided.

@gitbrent
Copy link
Owner

Needs some work: We cannot just remove Math.round(), we'll end up with a regression.

@Martin-N
Copy link
Author

Martin-N commented Jan 4, 2021 •
edited
Loading

I didn't just remove the Math.round(), I multiplied the font size by a hundred and removed the added '00'. The problem was that '00' was added at the end of the font size value. So if a decimal value came through it became 7.500 but needed to be 750. By multiplying the font size by 100 fixes that issue. You can test it. It works fine.

@Martin-N Martin-N changed the title Allow decimal fontsizes e.g. 7.5 Decimal fontsizes and Breakline Fix Mar 5, 2021
@Martin-N
Copy link
Author

Martin-N commented Mar 5, 2021

Sorry, new to git. Wanted to create a new pull request for the breakline fix, but I see it ended up in the decimal font fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement-text
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Martin-N @gitbrent