Report Git submodules as dependencies - #162
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enables Git submodules to be surfaced as dependency manifests by adding .gitmodules to the knowledge-base manifest discovery list, so the existing manifests parser can emit submodule URLs into manifests[] and dependencies[] as direct pkg:git dependencies.
Changes:
- Add
.gitmodulestoknowledge/_shared/_manifests.tomlsodetect.Engine.manifestPaths()includes it in dependency parsing. - Add a detection regression test ensuring
.gitmodulesis reported as agitmanifest and its submodules appear as direct runtime Git dependencies.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
knowledge/_shared/_manifests.toml |
Adds .gitmodules to the global manifest discovery list so it gets passed into dependency parsing. |
detect/detect_test.go |
Adds a regression test verifying .gitmodules is included in manifests[] and yields direct pkg:git dependencies for submodules. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
.gitmodulesto manifest discovery so the existing Git parser reports submodule URLs inmanifests[]anddependencies[]as directpkg:gitdependencies.Closes #151