Skip to content

Report Git submodules as dependencies - #162

Merged
andrew merged 1 commit into
mainfrom
fix/gitmodules-manifests
Aug 25, 2026
Merged

Report Git submodules as dependencies#162
andrew merged 1 commit into
mainfrom
fix/gitmodules-manifests

Conversation

@andrew

@andrew andrew commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Adds .gitmodules to manifest discovery so the existing Git parser reports submodule URLs in manifests[] and dependencies[] as direct pkg:git dependencies.

Closes #151

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables Git submodules to be surfaced as dependency manifests by adding .gitmodules to the knowledge-base manifest discovery list, so the existing manifests parser can emit submodule URLs into manifests[] and dependencies[] as direct pkg:git dependencies.

Changes:

  • Add .gitmodules to knowledge/_shared/_manifests.toml so detect.Engine.manifestPaths() includes it in dependency parsing.
  • Add a detection regression test ensuring .gitmodules is reported as a git manifest and its submodules appear as direct runtime Git dependencies.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
knowledge/_shared/_manifests.toml Adds .gitmodules to the global manifest discovery list so it gets passed into dependency parsing.
detect/detect_test.go Adds a regression test verifying .gitmodules is included in manifests[] and yields direct pkg:git dependencies for submodules.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@andrew
andrew merged commit 8fe9b60 into main Aug 25, 2026
9 checks passed
@andrew
andrew deleted the fix/gitmodules-manifests branch August 25, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pass .gitmodules to the manifests parser so submodule URLs appear in dependencies[]

2 participants