Skip to content

fix: assigning text to textContent should be html decoded, fixes #417 #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2025
Merged

fix: assigning text to textContent should be html decoded, fixes #417 #418

merged 1 commit into from
Aug 13, 2025

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Aug 13, 2025 •
edited
Loading

fixes #417

internal applyAsTextOrHtmlWhenEnabled() function should html decode value before passing them to textContent

with Fix

image

without Fix

image

@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions GitHub Actions
Copy link

Playwright E2E Test Results

83 tests  ±0   83 ✅ ±0   1m 40s ⏱️ +5s
73 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 5b470d7. ± Comparison against base commit 6ccbb5a.

@ghiscoding ghiscoding merged commit 6ed8ced into main Aug 13, 2025
3 checks passed
@ghiscoding ghiscoding deleted the bugfix/html-decode-label branch August 13, 2025 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rendering character &
1 participant
@ghiscoding