hal/vulkan: Increment counter for intermediate shaders #8066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
requested changes
Aug 14, 2025
wgpu-hal/src/vulkan/device.rs
Outdated
Comment on lines
1957
to
1958
|
|
||
| self.counters.shader_modules.sub(1); |
There was a problem hiding this comment.
I think this is the wrong fix to the problem, we should always be incrementing the counter, no matter what kind of shader module.
There was a problem hiding this comment.
👍, I've modified the code to do that, I took the liberty of refactoring it a bit to remove the early return so we only increment the counter in one place
DeltaEvo
force-pushed
the
david/vulkan_shader_count
branch
from
847afc7 to
9930b84
Compare
DeltaEvo
changed the title
DeltaEvo
force-pushed
the
david/vulkan_shader_count
branch
2 times, most recently
from
39381a0 to
d4dbe49
Compare
The counter is decremented for raw and intermediate shaders but only incremented for raw shaders, this lead to a negative counter value and did not represent the number of allocated shaders.
DeltaEvo
force-pushed
the
david/vulkan_shader_count
branch
from
d4dbe49 to
e8d7429
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The counter is decremented for raw and intermediate shaders but only incremented for raw shaders, this lead to a negative counter value and did not represent the number of allocated shaders.
Testing
Verified that the counter was not negative anymore and had an expected value
Squash or Rebase?
Rebase
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.