[egl] get rid of unwrap where possible
#8024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uael
force-pushed
the
uael/egl_less_panics
branch
2 times, most recently
from
a5736e2 to
ef685ac
Compare
uael
force-pushed
the
uael/egl_less_panics
branch
2 times, most recently
from
8a36522 to
dd86d76
Compare
Wumpf
requested changes
Aug 10, 2025
Wumpf
approved these changes
Aug 11, 2025
uael
force-pushed
the
uael/egl_less_panics
branch
2 times, most recently
from
573fe50 to
d4eda9f
Compare
Co-authored-by: Andreas Reich <[email protected]>
uael
force-pushed
the
uael/egl_less_panics
branch
from
4387f91 to
e6a83f1
Compare
|
Just to add a bit of context, this is fixing an |
MarijnS95
reviewed
Aug 11, 2025
Comment on lines
+513
to
+517
| fn instance_err<E: core::error::Error + Send + Sync + 'static>( | ||
| message: impl Into<String>, | ||
| ) -> impl FnOnce(E) -> crate::InstanceError { | ||
| move |e| crate::InstanceError::with_source(message.into(), e) | ||
| } |
There was a problem hiding this comment.
Would be much clearer if wgpu could define an anyhow-like context() trait for every Result. That should make it a lot less likely to loose source errors with other(), that I see a bunch of PRs do.
There was a problem hiding this comment.
sounds like an interseting idea, but out of scope for this pr either way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This try to handle egl errors instead of panicking out. I left some unwrap and expect where no
Resultwas returned.Testing
Manually tested.
Checklist
cargo fmt.Runtaplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.If this contains user-facing changes, add aCHANGELOG.mdentry.