Implement webgpu textureBindingViewDimension proposal to resolve texture view heuristics errors #8014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows platforms like GLES with EGL context backend to properly initialize such that their `EGLDisplay` and `EGLContext` are compatible with an incoming `Surface`, which is otherwise impossible if not for hotpatching the context (and loosing all resources created on it) when a surface comes in and that compositor connection becomes known. This hotpatching is known to break quite a few systems and initialization ordering (i.e. the alternative is forcing users to create surfaces before querying adapters, which isn't feasible on platform like Android), and is better avoided or at least made possible by using the `(Raw)DisplayHandle` abstraction provided by `raw_display_handle` in the way it's intended to be used (additionally, removing it from the surface would be a sensible decision). There may however be cases where users want to initialize multiple `Instance`s or perhaps `Adapter`s for independent `RawDisplayHandle`s, and certain backends may be designed specifically to cope with this (i.e. Vulkan). Note that this PR does nothing to address many other soundness problems inside the EGL backend.
…GLES texture view incompatibility
|
It's worth noting that this is currently a breaking change for every single create_texture call. |
|
Sorry I'm not sure this got on my radar - besides being based on the other PR - would want the final version of the PR to be without it - we do want this! |
Sorry a bit confused at the wording here - do you mean rebasing without #8012 ? Can do if so - just difficult to test without it. Is it okay that this is a breaking change for create_texture? If this is being used to implement WebGPU for Firefox I can imagine that the answer is that it can't be a feature flag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
RawDisplayHandleinInstanceDescriptor#8012 due to inability to run without it.Description
Originally posted by @tasogare3710 in #7428
Testing
Squash or Rebase?
Checklist
(keeping, as draft)
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.