Rework of wgpu_hal
vulkan buffer importing
#7824
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Discussed briefly with @cwfitzgerald in matrix chat.
Description
wgpu_hal
's vulkan buffer constructor to the buffer typefrom_raw_managed
, so that the buffer's memory can be managed bywgpu
rather than externallyTesting
Currently no testing. I don't believe there is any testing for the existing work either however.
Squash or Rebase?
Either works, there is only one commit at the moment.
Checklist
cargo fmt
.taplo format
.cargo clippy --tests
. If applicable, add:--target wasm32-unknown-unknown
cargo xtask test
to run tests.CHANGELOG.md
entry.