Repository navigation
Conversation
Author
|
There is a similar PR in the past #8696 that is closed. The solution from the user side is to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
This partially fix #4524.
Description
Motivatoin
Allow user to sample depth texture when using
GLbackend.Main changes
sampler2D. In order to be able to get the image's corresponding sampler,FunctionInfo::sampler_setis renamed tosampler_mapand useHashMapto get sampler.texture()in glsl always returnsvec4, add.rto convert it tofloatwhen sampling a depth texture.naga/tests/in/wgsl/4524-sample-depth.wgsl)Other changes
Running the test changes some of the files in
naga/tests/out.Drawbacks
User still can only use one sampler for each texture in GL backend.
So, if user sample from a depth texture, they can't use
textureSampleCompare()on it, vice versa.Testing
I have run all
nagatest, but notcargo xtask test, because it doesn't pass before the changes.I also tested this version of
wgpuon my own project.LLM Use?
Code is written by human.
I used LLM to learn something about OpenGL.
Checklist
CHANGELOG.mdentries for the user-facing effects of this change are present.wgpumay be affected behaviorally.