Repository navigation
Vulkan multi-planar DMA-buf import support - #10629
Open
andyleiserson wants to merge 4 commits into
Open
andyleiserson wants to merge 4 commits into
andyleiserson wants to merge 4 commits into
Conversation
Extract `import_dmabuf_fd`, which imports a DMA-buf as device memory with an optional dedicated image, and fold `create_image_without_memory_with_tiling` into `create_image_without_memory` and `create_vk_image`. Change `import_dmabuf_fd` and `import_dmabuf_memory` to take an owned file descriptor. It does not matter that much here, but it simplifies the (future) multi-plane version to take an owned FD, so change these to be consistent with that.
7 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for importing multi-planar DMA-bufs to the Vulkan HAL.
The primary motivation is supporting external textures in Firefox; it also fixes #9801.
It supports importing planes spread across multiple DMA-bufs (up to 4, imported with
VK_IMAGE_CREATE_DISJOINT_BIT), but this part is not tested, because my setup doesn't support it.More description to come later.
Testing
TBD. I have some LLM-generated tests on a local branch (not present in this PR).
Squash or Rebase?
Rebase
LLM Use?
Yes, LLM was used for code generation and refactoring. I have reviewed and polished all the code.
Checklist
CHANGELOG.mdentries for the user-facing effects of this change are present.wgpumay be affected behaviorally.