Repository navigation
gles: enable seamless cube map filtering on desktop GL - #10628
Open
kuntal-devrat wants to merge 1 commit into
Open
kuntal-devrat wants to merge 1 commit into
kuntal-devrat wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Fixes #10486
Description
Desktop OpenGL defaults to non-seamless cube map sampling (
GL_TEXTURE_CUBE_MAP_SEAMLESSdisabled), causing visible seam artifacts when filtering across cube map faces. In contrast, OpenGL ES 3.0+ and WebGL 2 mandate seamless cube map filtering by specification and don't require an enable flag, while Vulkan, Metal, and Direct3D 12 also sample cube maps seamlessly.Since
wgpu-halrequires at least OpenGL 3.3 for desktop GL,TEXTURE_CUBE_MAP_SEAMLESS(introduced in OpenGL 3.2 /GL_ARB_seamless_cube_map) is guaranteed to be supported whenever!self.shared.es.This PR enables
glow::TEXTURE_CUBE_MAP_SEAMLESSduring device initialization inAdapter::openon desktop OpenGL contexts.Testing
cargo test -p wgpu-hal --lib(passed).cargo clippy -p wgpu-hal --all-targets --all-features(0 warnings).cargo fmt --checkandcargo xtask sync-repo-files --check.Squash or Rebase?
Ready to rebase onto
trunk.LLM Use?
Assisted with investigating the issue, locating the initialization site in
wgpu-hal, and drafting the fix and description.Checklist
CHANGELOG.mdentries for the user-facing effects of this change are present.