Find all subheaders between headers regardless if they are siblings or children#107
Open
BoPeng wants to merge 1 commit intogfranko:masterfrom
BoPeng:all_headers
Open
Find all subheaders between headers regardless if they are siblings or children#107BoPeng wants to merge 1 commit intogfranko:masterfrom BoPeng:all_headers
BoPeng wants to merge 1 commit intogfranko:masterfrom
BoPeng:all_headers
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered a similar problem with #36. More specifically, I am adding TOCs to a bunch of jupyter notebooks whose headers are inside cells and have a structure like
tocify.js could not get the
h3s because they are not children ofh2. I checked the source code and find that this restriction is not really necessary so I modified the code to display all headers regardless if they are siblings or children.The patch works but perhaps not using the best algorithm, but I would first like to know if there is any real reason for the restriction and if you are interested in merging the PR.