feat(publish) Publish Secrets to Azure Key Vault #1240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
felixfontein
left a comment
felixfontein
left a comment
There was a problem hiding this comment.
Thanks for your contribution! I cannot say much about the functionality itself (in fact I've never used sops publish :) ), but I have some comments on the RST documentation.
Author
|
Thanks for the review, and sorry for the late follow-up. I've added the requested changes to the README.rst file, and merged current main. |
This appears to be only used for pushing Docker images to a registry we no longer have access to. As we need to rework the release process as a whole (using GitHub Actions), remove it for now. As the only thing it yields at present are failure notifications in my inbox. Signed-off-by: Hidde Beydals <[email protected]> Signed-off-by: Daniel Münch <[email protected]>
Signed-off-by: Daniel Münch <[email protected]>
Signed-off-by: Daniel Münch <[email protected]>
Signed-off-by: Daniel Münch <[email protected]>
Signed-off-by: Daniel Münch <[email protected]>
Signed-off-by: Daniel Münch <[email protected]> # Conflicts: # go.mod # go.sum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
first, thanks a lot for sops - a great tool which accommodates many of our needs in regards to secret management!
For our specific use-case, we needed to publish secrets to Azure Key Vault Secrets - While the general publish functionality of sops is useful, it currently lacks support to publish secrets to Azure Key Vault Secrets. This PR is an attempt to get this added.
Besides this, this PR also adds support for the
input-typecommand line flag to publish command .I'm a first-time contributor, and not too experienced Golang, so I hope I did things the right way. Happy to make any changes if required.
Regarding testing, there weren't any existing tests for the other publishers, so I couldn't just easily follow existing examples.