fix(gha-security-review): Pin third-party actions only - #166
Merged
Conversation
Align supply-chain guidance with internal policy: require full SHA pins for third-party actions in privileged jobs, and stop flagging first-party actions/* / github/* version tags as findings. Co-Authored-By: Greg Pstrucha <greg.pstrucha@sentry.io>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7e127fe. Configure here.
| # Find third-party actions pinned to branch names | ||
| grep -rn "uses:" .github/workflows/ \ | ||
| | grep -v "actions/\\|github/\\|\\./" \ | ||
| | grep -E "@(main|master|develop|latest)" |
There was a problem hiding this comment.
Detection greps miss third-party actions
Medium Severity
The new third-party filters use substring matches on actions/ and github/, so they drop common external actions whose names contain those strings — including tj-actions/*, aws-actions/*, and google-github-actions/*. Reviewers following these greps can miss unpinned supply-chain findings the rest of the doc still treats as reportable.
Reviewed by Cursor Bugbot for commit 7e127fe. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns
gha-security-reviewwith internal policy: pin third-party GitHub Actions, not first-party.The skill previously treated unpinned
actions/*/github/*version tags as medium findings ("defense in depth"), which caused false flags against our third-party-only pinning policy and disagreed with warden's builtinsecurity-reviewworkflow guidance.Changes
references/supply-chain.md: require full SHA pins only for third-party/external actions and reusable workflows; explicitly do not report first-partyactions/*/github/*version tags or same-repo/vendored actions as supply-chain pinning issues; gate reporting on job privilege; update detection greps, examples, and severity tableSKILL.md: tighten Check 6 and Safe Patterns to matchChecks
security-reviewgithub-workflows notesRisk
Low — skill text only. Reviewers should confirm org-owned internal actions wording matches expectations (treated as first-party within the org trust boundary).
Requested by Greg Pstrucha.
--
View Junior Session [Sentry]