-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
feat(autofix): Make comment thread rethinks manual #97053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+267
−99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #97053 +/- ##
=======================================
Coverage 80.68% 80.69%
=======================================
Files 8523 8523
Lines 374570 374554 -16
Branches 24334 24331 -3
=======================================
- Hits 302234 302228 -6
+ Misses 71960 71950 -10
Partials 376 376 |
jennmueng
reviewed
Aug 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we use the same icon as we use elsewhere for rethink? So it's more clear and people would associate actions with icons
@jennmueng done |
jennmueng
approved these changes
Aug 4, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Aug 4, 2025
Adds a UI for rethinking with comment threads as context manually. We will be removing automatic rethinks. <img width="356" height="278" alt="Screenshot 2025-08-02 at 10 25 07 AM" src="https://github.com/user-attachments/assets/498b89c1-732f-4391-8a4d-d083d6aaa4ee" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a UI for rethinking with comment threads as context manually. We will be removing automatic rethinks.
