Skip to content

chore(trace ai queries): Human readable queries #97050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore(trace ai queries): Human readable queries #97050

wants to merge 2 commits into from

Conversation

aayush-se
Copy link
Member

  • Include human readable queries for accessibility

@aayush-se aayush-se requested a review from a team as a code owner August 2, 2025 03:18
@aayush-se aayush-se requested a review from nsdeschenes August 2, 2025 03:19
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 2, 2025
cursor[bot]
cursor bot reviewed Aug 2, 2025
View reviewed changes
static/app/views/explore/components/queryTokens.tsx

if (groupBys && groupBys.length > 0) {
const groupByText = groupBys.length === 1 ? groupBys[0] : groupBys.join(', ');
parts.push(`groupBys are '${groupByText}'`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Accessibility Labels Use Incorrect Grammar

The generateQueryTokensString function incorrectly uses plural forms ("visualizations are", "groupBys are") in the accessibility label, even when only a single item is present. It should use singular forms ("visualization is", "groupBy is") for grammatical correctness.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@nsdeschenes nsdeschenes Awaiting requested review from nsdeschenes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aayush-se