feat(uptime): Optionally include uptime stats in organization_trace_meta
#97022
+143
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## danf/organization-uptime-trace #97022 +/- ##
==================================================================
- Coverage 80.66% 80.66% -0.01%
==================================================================
Files 8515 8511 -4
Lines 374885 374879 -6
Branches 24315 24315
==================================================================
- Hits 302404 302393 -11
- Misses 72104 72109 +5
Partials 377 377 |
evanpurkhiser
approved these changes
Aug 5, 2025
…meta` This adds `include_uptime` to the meta endpoint as well. When it's passed, we'll include the number of uptime spans in the meta as well Relies on #96821
wedamija
force-pushed
the
danf/organization-uptime-trace-meta
branch
from
bb41dbf to
eed8c9e
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| uptime_count = extract_uptime_count(uptime_result) | ||
| except Exception: | ||
| logger.exception("Failed to fetch uptime results") | ||
| return Response(self.serialize(results, perf_issues, uptime_count)) |
There was a problem hiding this comment.
Bug: API Inconsistency: Missing Uptime Checks Field
The OrganizationTraceMetaEndpoint omits the uptime_checks field from the response when include_uptime=1 and the uptime query fails. This occurs because the uptime_count variable remains None in the exception handler. Clients expect uptime_checks to always be present (even if 0) when include_uptime=1, leading to inconsistent API behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
include_uptimeto the meta endpoint as well. When it's passed, we'll include the number of uptime spans in the meta as wellRelies on #96821