This repository was archived by the owner on Aug 30, 2023. It is now read-only.
Benchmark test case for profiler #70
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the code we used to measure the performance overhead for the Python profiler. We have opened this PR to document the how to reproduce our benchmark test; we intend to keep it as a draft PR, as it does not need to get merged into the main branch.
In order to reproduce the trial we conducted, clone the repository, and check out this pull request. Then, follow the instructions here to run the benchmark. Please note: the benchmark does not run on the M1 Mac; we performed the benchmarking on an Ubuntu 22.04 Google Cloud VM.
The metric we used to measure overhead was the percent difference between the p90 latency for the server instrumented with the profiler and Sentry compared with the server instrumented with sentry but not the profiler. To calculate this difference, open the
report.htmlfile that is generated when the benchmark finishes. Scroll down to the table which displays the server latencies. Calculate the percent difference as follows:In the above equation,
instrumented_nylas_p90_latencyandinstrumented_p90_latencyare the 90th percentile latencies for the instrumented_nylas (profiled) and instrumented (non-profiled) runs, respectively.