-
-
Notifications
You must be signed in to change notification settings - Fork 167
feat(core): add some DSC fields to transaction envelope headers #869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #869 +/- ##
==========================================
+ Coverage 72.69% 73.14% +0.44%
==========================================
Files 64 64
Lines 7351 7365 +14
==========================================
+ Hits 5344 5387 +43
+ Misses 2007 1978 -29 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have some suggestions
41e40a1
to
e1a1c7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, see two comments before merge (both optional)
e1a1c7e
to
28eab25
Compare
a254c3b
to
34cbb3f
Compare
Adds the necessary DSC fields to solve the metrics extrapolation issue.
Close #865