Skip to content

feat(core): add some DSC fields to transaction envelope headers #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Jul 28, 2025

Conversation

lcian
Copy link
Member

@lcian lcian commented Jul 24, 2025

Adds the necessary DSC fields to solve the metrics extrapolation issue.
Close #865

Copy link

github-actions bot commented Jul 24, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 8ebbc35

Copy link

codecov bot commented Jul 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.14%. Comparing base (611b2cd) to head (8ebbc35).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #869      +/-   ##
==========================================
+ Coverage   72.69%   73.14%   +0.44%     
==========================================
  Files          64       64              
  Lines        7351     7365      +14     
==========================================
+ Hits         5344     5387      +43     
+ Misses       2007     1978      -29     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lcian lcian marked this pull request as ready for review July 24, 2025 11:59
@lcian lcian requested a review from szokeasaurusrex July 24, 2025 11:59
Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have some suggestions

@lcian lcian force-pushed the lcian/feat/dsc-info-for-transactions branch from 41e40a1 to e1a1c7e Compare July 25, 2025 07:33
Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, see two comments before merge (both optional)

@lcian lcian force-pushed the lcian/feat/dsc-info-for-transactions branch from e1a1c7e to 28eab25 Compare July 28, 2025 15:12
@lcian lcian force-pushed the lcian/feat/dsc-info-for-transactions branch from a254c3b to 34cbb3f Compare July 28, 2025 16:00
Base automatically changed from lcian/feat/envelope-headers/accessors to master July 28, 2025 16:05
@lcian lcian merged commit a425962 into master Jul 28, 2025
19 checks passed
@lcian lcian deleted the lcian/feat/dsc-info-for-transactions branch July 28, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send some DSC information in envelope header
2 participants