Skip to content

fix(logs): check if record should be handled within handle method #1888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2025
Merged

fix(logs): check if record should be handled within handle method #1888

merged 1 commit into from
Sep 2, 2025

Conversation

Litarnus
Copy link
Contributor

@Litarnus Litarnus commented Sep 1, 2025 •
edited
Loading

This PR adds a check into the handle method because isHandling does not guarantee to be called or that the result is respected, so an explicit check during handle is required.

@Litarnus Litarnus marked this pull request as ready for review September 1, 2025 16:33
@Litarnus Litarnus requested a review from stayallive September 1, 2025 16:33
@cleptric cleptric added the Bug label Sep 1, 2025
@Litarnus Litarnus merged commit 0425600 into master Sep 2, 2025
39 checks passed
@Litarnus Litarnus deleted the martinl/log-level-filter branch September 2, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stayallive stayallive stayallive approved these changes

Assignees

@Litarnus Litarnus

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Litarnus @stayallive @cleptric