fix(cloudflare): Allow non uuid workflow instance IDs #17121
Merged
+94
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
reviewed
Jul 23, 2025
packages/cloudflare/src/workflows.ts
Outdated
| if (!UUID_REGEX.test(instanceId)) { | ||
| throw new Error("Invalid 'instanceId' for workflow: Sentry requires random UUIDs for instanceId."); | ||
| } | ||
| async function hashStringToUuid(input: string): Promise<string> { |
There was a problem hiding this comment.
can we add some unit tests for this? Lets test some different kind of inputs.
There was a problem hiding this comment.
Also changed this to be called deterministicTraceIdFromInstanceId since that's what it actually does!
AbhiPrasad
approved these changes
Jul 23, 2025
AbhiPrasad
reviewed
Jul 23, 2025
timfish
force-pushed
the
timfish/feat/cloudflare-workflows-non-uuid
branch
from
7004f5c to
acd3ecf
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
AbhiPrasad
pushed a commit
that referenced
this pull request
Jul 24, 2025
- A backport to v9 of #17121 - Closes #17074 @StephenHaney unless you're a very early adopter of v10, this PR is probably the one you care about!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
instanceIdis not a uuid like string (ie. 32 hex characters with or without hyphens) we SHA1 hash theinstanceIdto create a uuid.