Skip to content

Feat/poc continuous profiling #4556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

Feat/poc continuous profiling #4556

wants to merge 21 commits into from
+5,268 −29

Conversation

lbloder
Copy link
Collaborator

@lbloder lbloder commented Jul 15, 2025

📜 Description

💡 Motivation and Context

Initial implementation of #2635

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

  • [] Investigate why TRACE lifecycle profiles do not show up in Sentry
  • [] Add external option for profile lifecycle

lbloder added 21 commits April 25, 2025 12:14
@lbloder
wip
f32782c
@lbloder
Merge branch 'main' into feat/poc-continuous-profiling
4fd36d2
@lbloder
re-add data category profile_chunk, fix json naming, new converter ba…
0e2a1b7 
…sed on jfr converter bundled with asyncprofiler
@lbloder
read java thread ids from jfr and use those instead of os thread ids,…
558ff79 
… use existing SentryStackFrame instead of JfrFrame,
@lbloder
adhere to sentry conventions re format null safety etc, fix compilation
04c82de
@lbloder
add profile-session-sample-rate to external options
f44e7fd
@lbloder
add platform as constructor param to ProfileChunk, wip: set java cont…
8b4c71a 
…inuous profiler in sentry init
@lbloder
add doubleToBigDecimal in JfrSample and ProfileChunk, same as we do i…
a44287b 
…t in SentrySpan to work around scientific notation of double, use wall clock profiling
@lbloder
Merge branch 'main' into feat/poc-continuous-profiling
0b39f7e 
# Conflicts:
#	sentry/build.gradle.kts
#	sentry/src/test/java/io/sentry/ExternalOptionsTest.kt
#	sentry/src/test/java/io/sentry/JsonSerializerTest.kt
#	sentry/src/test/java/io/sentry/SentryClientTest.kt
#	sentry/src/test/java/io/sentry/SentryOptionsTest.kt
@lbloder
rename JfrProfile to SentryProfile
9cf7ef6
@lbloder
move java profiling into its own module, load using SPI
5534204
@lbloder
[WIP] use getProfilingTracesDirPath
cabc384
@lbloder
add missing build.gradle.kts for profiler module
ec59901
@lbloder
Merge branch 'main' into feat/poc-continuous-profiling
54c3a8f
@lbloder
WIP continuous profiling in trace mode
543fc40
@lbloder
cleanup unused classes from vendor, cleanup packages
fba1881
@lbloder
allow setting profiling-traces-dir-path independently from cache dir …
55df61c 
…using external options
@lbloder
use profileChunk.platform to decide how to deal with the chunk instea…
9bcd4ea 
…d of file extension
@lbloder
port relevant AndroidContinuousProfilerTest tests to JavaContinuousPr…
3f83146 
…ofilerTest
@lbloder
add service loader tests for profiler and profile converter
4a7403a
@lbloder
remove old jfr test files
03a20dd
@github-actions GitHub Actions
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Feat/poc continuous profiling ([#4556](https://github.com/getsentry/sentry-java/pull/4556))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 03a20dd

@github-actions GitHub Actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 447.81 ms 457.62 ms 9.80 ms
Size 1.58 MiB 2.09 MiB 520.14 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adinauer adinauer Awaiting requested review from adinauer adinauer will be requested when the pull request is marked ready for review adinauer is a code owner

@romtsn romtsn Awaiting requested review from romtsn romtsn will be requested when the pull request is marked ready for review romtsn is a code owner

@stefanosiano stefanosiano Awaiting requested review from stefanosiano stefanosiano will be requested when the pull request is marked ready for review stefanosiano is a code owner

@markushi markushi Awaiting requested review from markushi markushi will be requested when the pull request is marked ready for review markushi is a code owner

@lcian lcian Awaiting requested review from lcian lcian will be requested when the pull request is marked ready for review lcian is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lbloder