Skip to content

feat: Document eventLoopBlockIntegration integration #14302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2025

Conversation

AbhiPrasad
Copy link
Member

DESCRIBE YOUR PR

resolves https://linear.app/getsentry/issue/FE-521

This PR documents the eventLoopBlockIntegration we added in in the new @sentry/node-native package.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.): This has already been released, so we should merge asap.
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@AbhiPrasad AbhiPrasad requested a review from timfish July 9, 2025 13:07
@AbhiPrasad AbhiPrasad self-assigned this Jul 9, 2025
Copy link

vercel bot commented Jul 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2025 3:19pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2025 3:19pm

@AbhiPrasad AbhiPrasad marked this pull request as ready for review July 9, 2025 13:07
@AbhiPrasad AbhiPrasad requested review from a team, Lms24 and RulaKhaled and removed request for a team July 9, 2025 13:08
Copy link
Collaborator

@timfish timfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Just a little nit because the new integration always captures stack traces.

Should we reference Application Not Responding (ANR) less because we dont call it that now?

@@ -32,7 +32,7 @@ keywords:
]
---

Application Not Responding (ANR) errors, or Event Loop Stall errors, are triggered when the Node.js main thread event loop of an application is blocked for more than five seconds. The Node SDK reports ANR errors as Sentry events and can optionally attach a stack trace of the blocking code to the ANR event.
Application Not Responding (ANR) errors, or Event Loop Stall errors, are triggered when the Node.js main thread event loop of an application is blocked for more than a specified threshold. The Node SDK reports ANR errors as Sentry events and can optionally attach a stack trace of the blocking code to the ANR event.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capturing stack traces is not optional in the new integration

@AbhiPrasad
Copy link
Member Author

Should we reference Application Not Responding (ANR) less because we dont call it that now?

yeah we should! Let me make that change.

Copy link

codecov bot commented Jul 9, 2025

Bundle Report

Changes will increase total bundle size by 31.62kB (0.14%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.9MB 31.63kB (0.27%) ⬆️
sentry-docs-client-array-push 9.81MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 878.27kB -0.0%
static/chunks/1831-*.js -3 bytes 421.22kB -0.0%
static/yQ2-*.js (New) 684 bytes 684 bytes 100.0% 🚀
static/yQ2-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/5R8feBxtO5B_HurIP3n2r/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/5R8feBxtO5B_HurIP3n2r/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.67MB -0.0%
../instrumentation.js -3 bytes 997.28kB -0.0%
9523.js -3 bytes 973.22kB -0.0%
../app/[[...path]]/page.js.nft.json 10.55kB 701.71kB 1.53%
../app/platform-redirect/page.js.nft.json 10.55kB 701.62kB 1.53%
../app/sitemap.xml/route.js.nft.json 10.55kB 699.6kB 1.53%

@AbhiPrasad AbhiPrasad merged commit 8974643 into master Jul 9, 2025
15 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-event-loop-block branch July 9, 2025 15:53
AbhiPrasad added a commit that referenced this pull request Jul 9, 2025
A bad rebase meant that this was not included with
#14302
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants