-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix(flutter): Add missing experimental for privacy options before GA #14014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The privacy options are not experimental anymore as the example shows to access via `options.privacy`, but there is still a mention of `options.experimental.privacy`
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch 🕵️
just checked this and its wrong the other way around actually, the code snippet should be |
Thanks for pointing this out @buenaflor. In that case I misunderstood the code in sentry-dart. I'll update the PR |
@philprime ah got it that's because the main branch is on v9 which is not released yet. once v9 is out I'll remove all the experimental fields from the docs |
updated the changes and pull request description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good double catch 😅 also didn't spot that it was part of the alpha & not released yet
DESCRIBE YOUR PR
The privacy options are still experimental but the example shows to access via
options.privacy
. This PR changes this tooptions.experimental.privacy
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: