Skip to content

fix(flutter): Add missing experimental for privacy options before GA #14014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2025

Conversation

philprime
Copy link
Contributor

@philprime philprime commented Jun 12, 2025

DESCRIBE YOUR PR

The privacy options are still experimental but the example shows to access via options.privacy. This PR changes this to options.experimental.privacy

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

The privacy options are not experimental anymore as the example shows to access via `options.privacy`, but there is still a mention of `options.experimental.privacy`
@philprime philprime self-assigned this Jun 12, 2025
Copy link

vercel bot commented Jun 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2025 2:43pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2025 2:43pm

Copy link

codecov bot commented Jun 12, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.91MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.77MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.64MB -0.0%
../instrumentation.js -3 bytes 973.36kB -0.0%
9523.js -3 bytes 949.31kB -0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 873.24kB -0.0%
static/chunks/7750-*.js -3 bytes 401.83kB -0.0%
static/MRYvmQtZI1oLBohrkt2HR/_buildManifest.js (New) 616 bytes 616 bytes 100.0% 🚀
static/MRYvmQtZI1oLBohrkt2HR/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/EXBbRPhru82ltUDtw0Blj/_buildManifest.js (Deleted) -616 bytes 0 bytes -100.0% 🗑️
static/EXBbRPhru82ltUDtw0Blj/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Copy link
Member

@JoshuaMoelans JoshuaMoelans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch 🕵️

@buenaflor
Copy link
Contributor

just checked this and its wrong the other way around actually, the code snippet should be options.experimental.privacy

@philprime
Copy link
Contributor Author

Thanks for pointing this out @buenaflor. In that case I misunderstood the code in sentry-dart. I'll update the PR

@buenaflor
Copy link
Contributor

buenaflor commented Jun 12, 2025

@philprime ah got it that's because the main branch is on v9 which is not released yet.

once v9 is out I'll remove all the experimental fields from the docs

@philprime
Copy link
Contributor Author

updated the changes and pull request description

Copy link
Member

@JoshuaMoelans JoshuaMoelans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good double catch 😅 also didn't spot that it was part of the alpha & not released yet

@philprime philprime changed the title fix(flutter): Remove invalid experimental option after GA fix(flutter): Add missing experimental for privacy options before GA Jun 13, 2025
@philprime philprime merged commit 56be86d into master Jun 13, 2025
12 checks passed
@philprime philprime deleted the philprime-patch-1 branch June 13, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants