Skip to content

Conversation

vgrozdanic
Copy link
Member

@vgrozdanic vgrozdanic commented Aug 13, 2025

Metrics have been deprecated on october 7th 2024, and since then it is not possible to send metrics.
This PR:

  • cleans up command send_metric which is invalid since last October.
  • upgrades sentry-core package to the latest version which has deprecated metrics

@vgrozdanic vgrozdanic force-pushed the vg/chore-remove-metrics branch 2 times, most recently from 053ae2a to 142919b Compare August 13, 2025 13:29
@vgrozdanic vgrozdanic marked this pull request as ready for review August 13, 2025 14:00
@vgrozdanic vgrozdanic requested review from szokeasaurusrex and a team as code owners August 13, 2025 14:00
@vgrozdanic vgrozdanic requested a review from lcian August 13, 2025 14:00
@vgrozdanic vgrozdanic force-pushed the vg/chore-remove-metrics branch from 142919b to 8f0cf5a Compare August 14, 2025 09:34
vgrozdanic added a commit to getsentry/sentry-docs that referenced this pull request Aug 14, 2025
Metrics have been deprecated since October 7th 2024, so this is no
longer valid, and we should remove instructions on how to send metrics,
because this doesn't even work.

This PR getsentry/sentry-cli#2710 will clean up
metrics commands in CLI, but this can be cleaned up separately.
@szokeasaurusrex
Copy link
Member

We will defer merging this PR until the next major.

I have linked this PR under #2713, so we remember to merge it when we are releasing the next major. In the meantime, I will mark this PR as a draft

@szokeasaurusrex szokeasaurusrex marked this pull request as draft August 18, 2025 09:10
@lcian
Copy link
Member

lcian commented Aug 25, 2025

Thanks @vgrozdanic!
In general it would be better to just upgrade the sentry dependency instead of adding/upgrading the one to sentry-core.
If you do it this way, you end up with a mix:

sentry-cli/Cargo.lock

Lines 2786 to 2811 in 8f0cf5a

[[package]]
name = "sentry-core"
version = "0.34.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "161283cfe8e99c8f6f236a402b9ccf726b201f365988b5bb637ebca0abbd4a30"
dependencies = [
"crc32fast",
"once_cell",
"rand 0.8.5",
"regex",
"sentry-types 0.34.0",
"serde",
"serde_json",
]
[[package]]
name = "sentry-core"
version = "0.42.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "deaa38b94e70820ff3f1f9db3c8b0aef053b667be130f618e615e0ff2492cbcc"
dependencies = [
"sentry-types 0.42.0",
"serde",
"serde_json",
"url",
]

In this case it shouldn't cause problems, as we're not using the SDK "as an SDK" (e.g. we're not using the Hub at all), but could cause problems if we need to do so in the future, so let's remember to just upgrade sentry and try to avoid adding direct dependencies to the subcrates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants