feat(logs): Handle inbound filters for logs #4938
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for the release inbound filter on logs. We currently do not support client ip because logs do not have an ip attribute.
AbhiPrasad
reviewed
Jul 14, 2025
Dav1dde
requested changes
Jul 14, 2025
There was a problem hiding this comment.
This is going to be a bigger change. Inbound filters must be evaluated in the first layer that is applicable. Meaning it cannot be guarded by a if is_processing as it is now.
Since this is the first thing which requires it, we will also have to move normalization to the same layer, as the filtering can depend on attributes of the normalization. As a result of this we will need a proper way of keeping track and validating the origin of the original byte count of a log.
Unfortunately this is now hitting your PR, but these steps were skipped when originally implementing logs, it is now catching up to us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the release inbound filter on logs. We currently do not support client ip because logs do not have an ip attribute.