Rename legacy ai.* attributes to gen_ai.* names.
#4924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgrozdanic
reviewed
Jul 9, 2025
| @@ -493,7 +493,7 @@ pub struct SpanData { | |||
| pub gen_ai_usage_output_tokens_reasoning: Annotated<Value>, | |||
|
|
|||
| // Exact model used to generate the response (e.g. gpt-4o-mini-2024-07-18) | |||
| #[metastructure(field = "gen_ai.response.model")] | |||
| #[metastructure(field = "gen_ai.response.model", legacy_alias = "ai.model_id")] | |||
There was a problem hiding this comment.
We should also remove ai_model_id field, since this is basically deprecating it. Not sure if it needs to be done as a part of this PR, or if follow-up is fine
| #[metastructure(field = "gen_ai.response.text", pii = "maybe")] | ||
| #[metastructure( | ||
| field = "gen_ai.response.text", | ||
| legacy_alias = "ai.responses", |
There was a problem hiding this comment.
This field also already exists ai_responses
loewenheim
reviewed
Jul 9, 2025
Comment on lines
-1058
to
+1059
| "gen_ai.agent.name": "Seer", | ||
| "gen_ai.system": "openai" | ||
| "gen_ai.system": "openai", | ||
| "gen_ai.agent.name": "Seer" |
There was a problem hiding this comment.
Can you revert this? They were alphabetical before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the names OTel compatible and also allows older SDKs that use the legacy names to send spans that will appear in the AI agents insights module.
Those are matching the deprecated
ai.*attributes described in the Sentry conventions:https://getsentry.github.io/sentry-conventions/generated/attributes/ai.html#deprecated-attributes
We have checked if those attributes are used by customers in alerts, dashboards and saved queries. They are NOT used, so we can safely normalize them.
Fixes getsentry/sentry-python#4516