Skip to content

fix(nel): Change attribute to nel.elapsed_time #4919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

fix(nel): Change attribute to nel.elapsed_time #4919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26b8133
fix(nel): Change attribute to nel.elapsed_time
armenzg Jul 8, 2025
bacfb15
Updated snapshots
armenzg Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion relay-event-normalization/src/normalize/nel.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,6 @@ pub fn create_log_with_trace_id(
add_string_attribute!("url.domain", &url_domain);
}
add_attribute!("url.full", raw_report.url);
add_attribute!("http.request.duration", body.elapsed_time);
add_attribute!("http.request.method", body.method);
add_attribute!("http.request.header.referer", body.referrer.clone());
add_attribute!("http.response.status_code", body.status_code);
Expand All @@ -280,6 +279,7 @@ pub fn create_log_with_trace_id(
}

// NEL-specific attributes
add_attribute!("nel.elapsed_time", body.elapsed_time);
add_attribute!("nel.referrer", body.referrer);
add_attribute!("nel.phase", body.phase.map_value(|s| s.to_string()));
add_attribute!("nel.sampling_fraction", body.sampling_fraction);
Expand Down
8 changes: 4 additions & 4 deletions ...rmalize/snapshots/relay_event_normalization__normalize__nel__tests__create_log_basic.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,6 @@ expression: "SerializableAnnotated(&Annotated::new(log))"
"type": "string",
"value": "network-error"
},
"http.request.duration": {
"type": "integer",
"value": 1000
},
"http.request.header.referer": {
"type": "string",
"value": "https://example.com/referer"
Expand All @@ -28,6 +24,10 @@ expression: "SerializableAnnotated(&Annotated::new(log))"
"type": "integer",
"value": 500
},
"nel.elapsed_time": {
"type": "integer",
"value": 1000
},
"nel.phase": {
"type": "string",
"value": "application"
Expand Down
8 changes: 4 additions & 4 deletions ...ize/snapshots/relay_event_normalization__normalize__nel__tests__create_log_dns_error.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,14 @@ expression: "SerializableAnnotated(&Annotated::new(log))"
"type": "string",
"value": "network-error"
},
"http.request.duration": {
"type": "integer",
"value": 2000
},
"http.request.method": {
"type": "string",
"value": "POST"
},
"nel.elapsed_time": {
"type": "integer",
"value": 2000
},
"nel.phase": {
"type": "string",
"value": "dns"
Expand Down
Loading