-
Notifications
You must be signed in to change notification settings - Fork 101
feat(playstation): Skip large attachments #4793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tobias-wilfert
merged 9 commits into
master
from
tobias-wfilert/feat/ignore-large-files
Jun 10, 2025
Merged
feat(playstation): Skip large attachments #4793
tobias-wilfert
merged 9 commits into
master
from
tobias-wfilert/feat/ignore-large-files
Jun 10, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobias-wilfert
commented
Jun 4, 2025
Dav1dde
approved these changes
Jun 10, 2025
…etsentry/relay into tobias-wfilert/feat/ignore-large-files
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 18, 2025
Currently there is no communication to the user about a field being skipped. This PR adds the logic for emitting outcomes for skipped fields such that the users are aware of these skipped fields. Follow up to: #4793
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a multi part form skip large attachments if the overall body size is not exceeded rather than stoping at the first field that is too large.
Part of: https://linear.app/getsentry/issue/TEMPEST-23/add-logic-to-discard-large-fields
Follow ups:
attachment_size
andattachments_size
in the relay configs: Turned out to not be necessary