Fixes getodk/central#1185: Add support for $search in /entities.csv #1605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadiqkhoja
force-pushed
the
fixes/1185-search-entity-csv
branch
from
ea0b8f3 to
6081e49
Compare
sadiqkhoja
force-pushed
the
fixes/1185-search-entity-csv
branch
from
6081e49 to
c93620b
Compare
matthew-white
approved these changes
Sep 7, 2025
There was a problem hiding this comment.
I reviewed the Frontend part of this (getodk/central-frontend#1336), so I thought I'd quickly review the Backend as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of getodk/central#1185
What has been done to verify that this works as intended?
Added couple of tests.
Why is this the best possible solution? Were any other approaches considered?
Uses existing approach.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
None
Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.
Updated.
Before submitting this PR, please make sure you have:
make testand confirmed all checks still pass OR confirm CircleCI build passes