Add tests folder with nao init#762
Merged
Merged
Conversation
2c6a554 to
4e1a856
Compare
Contributor
🧹 Preview RemovedThe preview deployment for this PR has been cleaned up. |
773f2d8 to
aed2779
Compare
nao init
aed2779 to
794b8d9
Compare
Contributor
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="cli/nao_core/commands/init.py">
<violation number="1" location="cli/nao_core/commands/init.py:98">
P2: The newly scaffolded `tests/test_example.yml` is always overwritten on re-init, which can silently erase user changes.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| CreatedFile(path=Path("RULES.md"), content=None), | ||
| CreatedFile(path=Path(".naoignore"), content="templates/\n*.j2\ntests/\n"), | ||
| CreatedFile( | ||
| path=Path("tests/test_example.yml"), |
Contributor
There was a problem hiding this comment.
P2: The newly scaffolded tests/test_example.yml is always overwritten on re-init, which can silently erase user changes.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At cli/nao_core/commands/init.py, line 98:
<comment>The newly scaffolded `tests/test_example.yml` is always overwritten on re-init, which can silently erase user changes.</comment>
<file context>
@@ -94,6 +94,10 @@ def create_empty_structure(project_path: Path) -> tuple[list[str], list[CreatedF
CreatedFile(path=Path("RULES.md"), content=None),
CreatedFile(path=Path(".naoignore"), content="templates/\n*.j2\ntests/\n"),
+ CreatedFile(
+ path=Path("tests/test_example.yml"),
+ content=("name: test_example\nprompt: What is the result of 1+1?\nsql: |\n SELECT 2 AS answer_integer\n"),
+ ),
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/basic_arithmetic.ymlfile duringnao init.tests/in.naoignoreso local test outputs/data stay out of synced context..naoignoreentry and sample test file.Why
New projects already created a
tests/directory, but it was empty. That left users without a working example for the expected test YAML format.Validation
uv run pytest tests/nao_core/commands/test_init.pyuv run ruff check nao_core/commands/init.py tests/nao_core/commands/test_init.pyFixes #756.