Skip to content

fix(frontend): improve chart contrast in dark mode#742

Merged
Bl3f merged 1 commit into
getnao:mainfrom
nehaaprasaad:fix/drk-mod-contr-chrt-col
May 11, 2026
Merged

fix(frontend): improve chart contrast in dark mode#742
Bl3f merged 1 commit into
getnao:mainfrom
nehaaprasaad:fix/drk-mod-contr-chrt-col

Conversation

@nehaaprasaad
Copy link
Copy Markdown
Contributor

@nehaaprasaad nehaaprasaad commented May 7, 2026

Summary

  • Improves readability of chart titles and series colors in dark mode. Light mode and PNG chart export behavior stay sensible (title fallback on export).

Changes

  • Theme-aware SVG chart title fill with a safe fallback when CSS variables are not available.
  • Dark palette overrides for --chart-1–--chart-5 so bars and other series colors are not too dark on the dark background.
  • Explicit text-foreground on the chart toolbar title so it does not inherit muted parent text.

Files

apps/shared/src/chart-builder.tsx
apps/frontend/src/styles.css
apps/frontend/src/components/tool-calls/display-chart.tsx

fix : #667

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

🧹 Preview Removed

The preview deployment for this PR has been cleaned up.

Copy link
Copy Markdown
Contributor

@Bl3f Bl3f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Bl3f Bl3f merged commit 790ba15 into getnao:main May 11, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dark mode: poor contrast for chart titles and bar chart colors

2 participants