feat: export chart data as CSV#740
Open
nehaaprasaad wants to merge 1 commit intogetnao:mainfrom
Open
Conversation
Contributor
🚀 Preview Deployment
Preview will be automatically removed when this PR is closed. |
Contributor
There was a problem hiding this comment.
1 issue found across 6 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/shared/src/csv.ts">
<violation number="1" location="apps/shared/src/csv.ts:4">
P2: `escapeCsvCell` regex omits carriage return (`\r`) from characters that trigger CSV field quoting, which can break row boundaries per CSV spec</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| export function escapeCsvCell(value: unknown): string { | ||
| const str = value === null || value === undefined ? '' : String(value); | ||
| const sanitized = /^[=+\-@]/.test(str.trimStart()) ? `'${str}` : str; | ||
| return /[,"\n]/.test(sanitized) ? `"${sanitized.replace(/"/g, '""')}"` : sanitized; |
Contributor
There was a problem hiding this comment.
P2: escapeCsvCell regex omits carriage return (\r) from characters that trigger CSV field quoting, which can break row boundaries per CSV spec
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/shared/src/csv.ts, line 4:
<comment>`escapeCsvCell` regex omits carriage return (`\r`) from characters that trigger CSV field quoting, which can break row boundaries per CSV spec</comment>
<file context>
@@ -0,0 +1,45 @@
+export function escapeCsvCell(value: unknown): string {
+ const str = value === null || value === undefined ? '' : String(value);
+ const sanitized = /^[=+\-@]/.test(str.trimStart()) ? `'${str}` : str;
+ return /[,"\n]/.test(sanitized) ? `"${sanitized.replace(/"/g, '""')}"` : sanitized;
+}
+
</file context>
Suggested change
| return /[,"\n]/.test(sanitized) ? `"${sanitized.replace(/"/g, '""')}"` : sanitized; | |
| return /[,"\r\n]/.test(sanitized) ? `"${sanitized.replace(/"/g, '""')}"` : sanitized; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
How
Closes : #718