Set removal policy of dynamo db tables #381
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnapoli
approved these changes
Feb 17, 2024
Member
mnapoli
left a comment
mnapoli
left a comment
There was a problem hiding this comment.
LGTM, however the tests are failing, but I'm afraid it might be because tests on master are failing :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature adds support for setting the removal policy of a dynamodb table.
It is common in CI environments to setup/teardown constructs, serverless can be particularly difficult to test due to requiring AWS stack to correctly run an E2E test. Currently it is not possible to remove a serverless stack and have the database removed via lift as the default strategy is to retain the database (to avoid accidental deletion), this default is sensible.
The default should always be used for production or persistent environments. The optional property here allows developers to opt into automatic deletion which for CI makes life easier rather than having to script clean up of databases separately.