Return exit code on command failure instead of throwing#25
Merged
vijit-lark merged 2 commits intomainfrom Apr 14, 2026
Merged
Conversation
Add `finalized` and `cancelled` flags to WebSocketSession so the `close` event handler can distinguish graceful shutdowns from unexpected disconnects and log a warning with the close code/reason. Also adds `warn` to the Logger interface and all implementations, and bumps both packages to 0.10.0 (breaking: new required Logger method). Made-with: Cursor
Non-zero exit codes from command execution are now returned as part of the result instead of raising an error. When a command fails, remaining commands in the batch are skipped and only executed commands appear in the result message. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
finalizedandcancelledflags toWebSocketSessionso thecloseevent handler can distinguish graceful shutdowns from unexpected client disconnects, and logs a warning with the WebSocket close code and reason.warnto Logger: Addswarnmethod to theLoggerinterface and all implementations (createLogger,createRedactingLogger,defaultLogger).runtimeuseandruntimeuse-clientto0.10.0(breaking: new requiredwarnmethod onLogger, changed command failure behavior).Test plan
npm testinpackages/runtimeuse) to verify mock loggers and command failure behavior"All artifacts uploaded."and no warningexit 1) returns result withexit_code: 1instead of throwinguv run pytestinpackages/runtimeuse-client-python)