fix redactSecrets stack overflow on circular references#23
Merged
jackcbrown89 merged 2 commits intomainfrom Apr 14, 2026
Merged
fix redactSecrets stack overflow on circular references#23jackcbrown89 merged 2 commits intomainfrom
jackcbrown89 merged 2 commits intomainfrom
Conversation
Use a WeakMap to track visited objects and map them to their redacted results. This prevents infinite recursion and ensures secrets are redacted even through circular reference paths.
Contributor
Author
|
bugbot run |
Move recursive logic into a closure so the public signature stays as the documented two-parameter form.
Contributor
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit b5409af. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a WeakMap to track visited objects and map them to their redacted results. This prevents infinite recursion and ensures secrets are redacted even through circular reference paths.
Note
Medium Risk
Changes core redaction recursion to track and reuse seen objects/arrays; low behavioral surface area but could subtly affect identity/structure of returned objects for complex inputs.
Overview
Fixes
redactSecretsto safely handle circular references by tracking visited objects/arrays in aWeakMapand reusing the already-redacted result to avoid infinite recursion.Adds a regression test asserting circular structures are preserved (self-references point to the redacted clone) while still redacting secret strings.
Reviewed by Cursor Bugbot for commit b5409af. Bugbot is set up for automated code reviews on this repo. Configure here.