refact!: FieldClass with named props
#7608
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
distantnative
commented
Sep 28, 2025
distantnative
commented
Sep 28, 2025
distantnative
added
needs: discussion 🗣
distantnative
commented
Oct 12, 2025
| } | ||
|
|
||
| return $this->params[$param] ?? null; | ||
| throw new NotFoundException(message: 'Method or option "' . $param . '" does not exist for field type "' . $this->type() . '"'); |
Member
Author
There was a problem hiding this comment.
@bastianallgeier I was asking the other day about the magic validate prop that's not really defined anywhere. I guess this change would cause a problem with our magic usage there.
Member
There was a problem hiding this comment.
If we want to bring back this undocumented option for input fields, we should really do that in a way that sets a validate property and gets rid of the magic anyway.
bastianallgeier
force-pushed
the
v6/refact/fields-named-args
branch
2 times, most recently
from
560bfcd to
f9e6fd7
Compare
bastianallgeier
force-pushed
the
v6/refact/fields-named-args
branch
from
f9e6fd7 to
14fb5c2
Compare
distantnative
force-pushed
the
v6/refact/fields-named-args
branch
from
11d2441 to
5dd5edd
Compare
distantnative
force-pushed
the
v6/refact/fields-named-args
branch
from
5dd5edd to
48baca2
Compare
distantnative
removed
needs: discussion 🗣
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Todo
...$propsChangelog
🎉 Features
✨ Enhancements
🐛 Bug fixes
♻️ Refactored
☠️ Deprecated
🧹 Housekeeping
🚨 Breaking changes
Docs
For review team