Added rabbit connection pool to rabbit exchange implementation.#34
Open
raulincze wants to merge 3 commits intotopic-exchangefrom
Open
Added rabbit connection pool to rabbit exchange implementation.#34raulincze wants to merge 3 commits intotopic-exchangefrom
raulincze wants to merge 3 commits intotopic-exchangefrom
Conversation
raulincze
commented
Oct 1, 2022
|
|
||
| const ( | ||
| maxRequeueNo = 3 | ||
| defaultMaxConnections = 20 |
Contributor
Author
There was a problem hiding this comment.
This is misleading as the number is the max number of idle connections in the pool. The total number of connections can be larger. We might want a way to limit that, maybe having another chan for connection currently in use.
| connMu sync.RWMutex | ||
| } | ||
|
|
||
| func NewRabbitExchange(rabbitIni RabbitConfig) *RabbitExchangeImpl { |
Contributor
Author
There was a problem hiding this comment.
Need a way to pass the max connections from outside.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.