Fix/blink lightning address #3470
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2993
Problem
Previously, the "Receive" screen only displayed a Lightning Address QR code for Alby OAuth accounts. Blink (Galoy) wallets did not show a QR code because the
lightningAddresswas:Galoyconnector during setup.IndexedDBin theaddaction.infoAPI endpoint.Visual Comparison
Solution
This PR implements a full-stack fix to persist and display the address for Galoy accounts:
Backend / Connector
src/types.ts: ExtendedAccountinterface to includelightningAddress.galoy.ts: UpdatedgetInfo()to correctly derive the address (e.g.,[email protected]) from the username and globals.add.ts: Updated account creation logic to fetchconnector.getInfo()and persist thelightningAddressto storage immediately.info.ts: Updated the account info endpoint to bubble up thelightningAddressto the UI API response.Frontend
Receive/index.tsx: Removed the strictisAlbyOAuthUsercheck. The component now displays the QR code for any account that has a validlightningAddressavailable.Testing
IndexedDBand Sync Storage.