Skip to content

fix: modal height overflowing the screen, qr padding, size and remove show qr button when clicked #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolznz merged 1 commit into from
Feb 18, 2026
Merged

fix: modal height overflowing the screen, qr padding, size and remove show qr button when clicked #376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion dev/vite/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,11 @@
document
.getElementById('pay-button')
.addEventListener('click', async () => {
const payButtonInvoice = await ln.requestInvoice({satoshi: 1});
const payButtonInvoice = await ln.requestInvoice({
satoshi: 1,
//comment:
// "Lorem Ipsum is simply dummy text of the printing and typesetting industry. Lorem Ipsum has been the industry's standard dummy text ever since the 1500s",
});
document
.getElementById('pay-button')
.setAttribute('invoice', payButtonInvoice.paymentRequest);
Expand Down
4 changes: 2 additions & 2 deletions src/components/bc-modal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ export class Modal extends withTwind()(BitcoinConnectElement) {
@click=${this._handleClose}
></div>
<div
class="transition-all p-4 pt-6 pb-8 rounded-2xl shadow-2xl flex justify-center items-center w-full bg-white dark:bg-black max-w-md max-sm:rounded-b-none
animate-fade-in max-sm:animate-slide-up"
class="transition-all p-4 pt-6 pb-8 rounded-2xl shadow-2xl flex flex-col w-full bg-white dark:bg-black max-w-md max-sm:rounded-b-none
animate-fade-in max-sm:animate-slide-up max-h-[90vh] overflow-y-auto"
>
<slot @onclose=${this._handleClose}></slot>
</div>
Expand Down
18 changes: 11 additions & 7 deletions src/components/pages/bc-send-payment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,11 +128,13 @@ export class SendPayment extends withTwind()(BitcoinConnectElement) {
}

if (this.paymentMethods === 'all' || this.paymentMethods === 'external') {
externalMethods = html`
<bci-button block @click=${this._copyAndDisplayInvoice}>
${qrIcon} Copy & Display Invoice
</bci-button>
`;
if (!this._showQR) {
externalMethods = html`
<bci-button block @click=${this._copyAndDisplayInvoice}>
${qrIcon} Copy & Display Invoice
</bci-button>
`;
}

if (this._showQR) {
qrSection = this.renderQR();
Expand All @@ -150,7 +152,9 @@ export class SendPayment extends withTwind()(BitcoinConnectElement) {
: null}
${internalMethods} ${externalMethods}
</div>
${qrSection}
${qrSection
? html`<div class="mt-4 flex flex-col items-center">${qrSection}</div>`
: null}
`;
}

Expand Down Expand Up @@ -216,7 +220,7 @@ export class SendPayment extends withTwind()(BitcoinConnectElement) {
qr.addData(invoice);
qr.make();
const moduleCount = qr.getModuleCount();
const scale = 4;
const scale = 2;
canvas.width = moduleCount * scale;
canvas.height = moduleCount * scale;

Expand Down