feat: add checkout session params + expand discount data in webhook#36
Open
alim888aa wants to merge 1 commit intoget-convex:masterfrom
Open
feat: add checkout session params + expand discount data in webhook#36alim888aa wants to merge 1 commit intoget-convex:masterfrom
alim888aa wants to merge 1 commit intoget-convex:masterfrom
Conversation
4ca331e to
9ca3adf
Compare
9ca3adf to
d9c0bf6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes issue #35
Adds optional parameters to
createCheckoutSession:allowPromotionCodes— enable promo code input on hosted checkoutpaymentMethodTypes— explicit payment method controlpaymentMethodOptions— method-specific configdiscounts— server-applied coupons/promotion codeslocale— checkout page languagecurrency— currency overrideAlso expands discount/promotion code data in the
checkout.session.completedwebhook handler viastripe.checkout.sessions.retrieve()withexpand: ["discounts.promotion_code"], so custom handlers can read the promotion code string directly without additional API calls. This follows the existing pattern whereprocessEventalready retrieves subscriptions/invoices for subscription mode.All new parameters are optional. Existing behavior is unchanged. Includes a runtime guard for the mutually exclusive
allowPromotionCodes/discountsparams.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.