Add checkout promotion code and UI params#16
Open
mbokinala wants to merge 1 commit intoget-convex:masterfrom
Open
Add checkout promotion code and UI params#16mbokinala wants to merge 1 commit intoget-convex:masterfrom
mbokinala wants to merge 1 commit intoget-convex:masterfrom
Conversation
|
Hoping this gets added |
|
Wouldnt it make sense to support the full stripe API for creating checkout sessions? |
|
When can this get added? |
josefmay
reviewed
Feb 7, 2026
Comment on lines
+163
to
+164
| allow_promotion_codes?: boolean | ||
| ui_mode?: "custom" | "embedded" | "hosted" |
There was a problem hiding this comment.
Should format the parameters name to match the others
|
Would really appreciate the promotion code option. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
allow_promotion_codesandui_modeparams toStripeSubscriptions.createCheckoutSession().This PR resolves #15.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.